Monorepo for Tangled โ€” https://tangled.org

appview: wrap posthog under unified notifier #333

merged
opened by boltless.me targeting master from boltless.me/core: push-pslnqmxvulmp
  • Make db.New*() methods to accept complete model object instead of individual fields
  • Remove posthog field from most Service structs. Oauth still has one as an edge-case
  • Add more notifier methods to replace posthog logics

Signed-off-by: Seongmin Lee boltlessengineer@proton.me

0
by boltless.me 0 comments
expand 1 commit
appview: wrap posthog under unified notifier
sign up or login to add to the discussion
1
by boltless.me 1 comment
expand 1 commit
appview: wrap posthog under unified notifier

This PR does nothing but wrapping existing logic with internal notify system. We can benefit from this after we have more complex listeners like search indexer / webhooks.

sign up or login to add to the discussion
2
by boltless.me 2 comments
expand 1 commit
appview: wrap posthog under unified notifier

this stack looks good! its very nicely split up, i appreciate the time you spent on this!

minor nit: here, can we use repo.RepoAt(), i've been meaning to deprecate the AtUri field in the DB (and have it be calculated from the components).

@oppi.li fixed. Thank you for reviewing.

sign up or login to add to the discussion
3
by boltless.me 1 comment
expand 1 commit
appview: wrap posthog under unified notifier

thanks for your work on this! this now opens us up to do a variety of cool additions:

  • per-user inbox
  • issue/pull-request event updates (and potentially webmentions)

thanks again!

pull request successfully merged
sign up or login to add to the discussion
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3lujkd33caq22