Signed-off-by: nelind nel.n.lindberg@gmail.com
appview: pages: refactor base layout to be one big grid so we can avoid min-h-screen workarounds that cause permanent scrolling #359
expand 1 commit
hide 1 commit
Signed-off-by: nelind <nel.n.lindberg@gmail.com>
expand 1 commit
hide 1 commit
Signed-off-by: nelind <nel.n.lindberg@gmail.com>
both seemed reasonable to me! changed the mt-16 on footer to mt-12 as well to account for the gap-4 there too
i also noticed that the footer has rounded-t while the header has rounded. would probably make sense to change that to a rounded-b to match the footer. idk if thats straying off the point of this PR stack a bit though? might make better sense in a later PR or as just a plain commit. (its not like i dont also have more things i want to change here eventually so. like the semantic HTML stuff and eventually refactoring commit/patch/compare/interdiff out so they all use a combined "wide layout" base or something of the sort)
this is great! thanks for the submission. couple of changes:
mb-4which can be removed now that body hasgap-4col-span-fullas opposed tocol-span-1 md:col-span-12?