back round 0 view raw

knotserver: minor fixups to xrpc APIs #369

merged

opened by

oppi.li 4 months ago targeting master from push-mqkxnymrqmzz

Signed-off-by: oppiliappan me@oppi.li

options

unified split

Changed files

+3 -3

knotserver

xrpc

router.go

set_default_branch.go

+1 -1

knotserver/xrpc/router.go

···

       134
        
       

     

       135
        
       func GenericError(err error) XrpcError {

     

       136
        
       	return NewXrpcError(

     

       137
       -
       		WithTag("InvalidRepo"),

     

       138
        
       		WithError(err),

     

       139
        
       	)

     

       140
        
       }

···

       134
        
       

     

       135
        
       func GenericError(err error) XrpcError {

     

       136
        
       	return NewXrpcError(

     

       137
       +
       		WithTag("Generic"),

     

       138
        
       		WithError(err),

     

       139
        
       	)

     

       140
        
       }

+2 -2

knotserver/xrpc/set_default_branch.go

···

       23
        
       		writeError(w, e, http.StatusBadRequest)

     

       24
        
       	}

     

       25
        
       

     

       26
       -
       	actorDid, ok := r.Context().Value(ActorDid).(*syntax.DID)

     

       27
        
       	if !ok {

     

       28
        
       		fail(MissingActorDidError)

     

       29
        
       		return

     
···

       83
        
       		return

     

       84
        
       	}

     

       85
        
       

     

       86
       -
       	w.WriteHeader(http.StatusNoContent)

     

       87
        
       }

···

       23
        
       		writeError(w, e, http.StatusBadRequest)

     

       24
        
       	}

     

       25
        
       

     

       26
       +
       	actorDid, ok := r.Context().Value(ActorDid).(syntax.DID)

     

       27
        
       	if !ok {

     

       28
        
       		fail(MissingActorDidError)

     

       29
        
       		return

     
···

       83
        
       		return

     

       84
        
       	}

     

       85
        
       

     

       86
       +
       	w.WriteHeader(http.StatusOK)

     

       87
        
       }