tangled.org / core
Monorepo for Tangled — https://tangled.org
fork atom

lexicons: pulls: add stack information to pull records #405

open
opened by nel.pet targeting master from nel.pet/core: push-kyupnpkvqmsy
STACK 5
#406 lexicons: pulls: pull rounds out into their own records
2
#0
#405 lexicons: pulls: add stack information to pull records
0
#3
#404 lexicons: pulls: put target repo and branch together in their own object
0
#3
#403 lexicons: pulls: remove pull id from the pull record and instead generate ids purely appview side
0
#3
#402 lexicons: pulls: remove repo, commentId and owner fields from pull comment records
0
#3
0
by nel.pet 1 comment
expand 1 commit
64034723
lexicons: pulls: add stack information to pull records
oppi.li
  • you probably meant to remove this!
  • we can avoid the error checks for ATURI parsing here and here since its clear that those ATURIs are valid.

the code changes here lgtm! i am a but rusty on the resubmit logic, so i will have a poke around locally with that.

sign up or login to add to the discussion
1
by nel.pet 1 comment
expand 1 commit
12a3fb33
lexicons: pulls: add stack information to pull records
nel.pet
  • yea that was a debug print i accidentally left in woops ..
  • removed the error checks and added a comment on why the errors are ignored! i tested it out locally just as a sanity test but yea its not .. the simplest logic ever
sign up or login to add to the discussion
2
by nel.pet 0 comments
expand 1 commit
9fd7b9f3
lexicons: pulls: add stack information to pull records
sign up or login to add to the discussion
3
by nel.pet 0 comments
expand 1 commit
060f0d62
lexicons: pulls: add stack information to pull records
failed to check merge status: invalid xrpc request
sign up or login to add to the discussion
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:h5wsnqetncv6lu2weom35lg2/sh.tangled.repo.pull/3lvos45stdx22