tangled.org / core
Monorepo for Tangled — https://tangled.org
fork atom

appview: improve pagination.Page usage #519

closed
opened by ptr.pet targeting master from ptr.pet/core: pipeline-paginated
STACK 3
#521 appview: implement pagination for pipelines index
1
#3
#520 appview: db: add FilterBetween
0
#2
#519 appview: improve pagination.Page usage
0
#3
0
by ptr.pet 1 comment
expand 1 commit
8ee73a8a
appview: improve pagination.Page usage
oppi.li

this helper is quite strange. can we use a slightly better API? the page size does not belong in the FirstPage method (although i understand it was previously hardcoded here).

we can do something like p := NewPagination(WithSize(N), WithOffset(0), WithTotal(...)) and have p.FirstPage() perhaps.

sign up or login to add to the discussion
1
by ptr.pet 1 comment
expand 1 commit
1af31ddd
appview: improve pagination API
ptr.pet

i went with a page number api and made pagination produce pages instead, i think it fits it better (pagination still uses offset / limit / total though ofc)

sign up or login to add to the discussion
2
by ptr.pet 0 comments
expand 1 commit
93bdc6bc
appview: improve pagination API
sign up or login to add to the discussion
3
by ptr.pet 0 comments
expand 1 commit
eda039f3
appview: improve pagination API
closed without merging
sign up or login to add to the discussion
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:dfl62fgb7wtjj3fcbb72naae/sh.tangled.repo.pull/3lwubheua2u22