back interdiff of round #4 and #3

knotserver: set default git committer user via config #529

merged
opened by boltless.me targeting master from boltless.me/core: push-skprtmnmwuqn

Introducing KNOT_GIT_USER_NAME and KNOT_GIT_USER_EMAIL environment variables.

This will prevent silently inheritting global gitconfig's user

Signed-off-by: Seongmin Lee boltlessengineer@proton.me

files
knotserver
ERROR
knotserver/config/config.go

Failed to calculate interdiff for this file.

ERROR
knotserver/git/merge.go

Failed to calculate interdiff for this file.

REVERTED
knotserver/routes.go
···
}
mo := git.MergeOptions{
-
AuthorName: data.AuthorName,
-
AuthorEmail: data.AuthorEmail,
-
CommitterName: h.c.Git.UserName,
-
CommitterEmail: h.c.Git.UserEmail,
-
CommitBody: data.CommitBody,
-
CommitMessage: data.CommitMessage,
FormatPatch: patchutil.IsFormatPatch(patch),
}
···
}
mo := git.MergeOptions{
+
AuthorName: data.AuthorName,
+
AuthorEmail: data.AuthorEmail,
+
CommitBody: data.CommitBody,
+
CommitMessage: data.CommitMessage,
FormatPatch: patchutil.IsFormatPatch(patch),
}
NEW
knotserver/xrpc/merge.go
···
mo.CommitMessage = *data.CommitMessage
}
mo.FormatPatch = patchutil.IsFormatPatch(data.Patch)
err = gr.MergeWithOptions([]byte(data.Patch), data.Branch, mo)
···
mo.CommitMessage = *data.CommitMessage
}
+
mo.CommitterName = x.Config.Git.UserName
+
mo.CommitterEmail = x.Config.Git.UserEmail
mo.FormatPatch = patchutil.IsFormatPatch(data.Patch)
err = gr.MergeWithOptions([]byte(data.Patch), data.Branch, mo)