back round 0 view raw

knotserver: fix sort order of tags #610

merged

opened by

oppi.li 2 months ago targeting master from push-okxlrwoolxpr

the output produced by for-each-rev is lexicographic.

Signed-off-by: oppiliappan me@oppi.li

options

unified split

Changed files

+10 -1

knotserver

git

tag.go

+10 -1

knotserver/git/tag.go

···

       94
        
       		tags = append(tags, tag)

     

       95
        
       	}

     

       96
        
       

     

       97
       -
       	slices.Reverse(tags)

     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       98
        
       	return tags, nil

     

       99
        
       }

···

       94
        
       		tags = append(tags, tag)

     

       95
        
       	}

     

       96
        
       

     

       97
       +
       	slices.SortFunc(tags, func(a, b object.Tag) int {

     

       98
       +
       		if a.Tagger.When.After(b.Tagger.When) {

     

       99
       +
       			return -1

     

       100
       +
       		}

     

       101
       +
       		if b.Tagger.When.After(a.Tagger.When) {

     

       102
       +
       			return 1

     

       103
       +
       		}

     

       104
       +
       		return 0

     

       105
       +
       	})

     

       106
       +
       

     

       107
        
       	return tags, nil

     

       108
        
       }