back round 1 view raw

knotserver: fix sort order of tags #610

merged
opened by oppi.li targeting master from push-okxlrwoolxpr

the output produced by for-each-rev is lexicographic.

Signed-off-by: oppiliappan me@oppi.li

options
unified split
Changed files
+1 -3
knotserver
git
tag.go
+1 -3
knotserver/git/tag.go 
···

       
2

       
 

       



     

       
3

       
 

       
import (


     

       
4

       
 

       
	"fmt"


     

       
5

       
-

       
	"slices"


     

       
6

       
 

       
	"strconv"


     

       
7

       
 

       
	"strings"


     

       
8

       
 

       
	"time"


     
···

       
35

       
 

       
	outFormat.WriteString("")


     

       
36

       
 

       
	outFormat.WriteString(recordSeparator)


     

       
37

       
 

       



     

       
38

       
-

       
	output, err := g.forEachRef(outFormat.String(), "refs/tags")


     

       
39

       
 

       
	if err != nil {


     

       
40

       
 

       
		return nil, fmt.Errorf("failed to get tags: %w", err)


     

       
41

       
 

       
	}


     
···

       
94

       
 

       
		tags = append(tags, tag)


     

       
95

       
 

       
	}


     

       
96

       
 

       



     

       
97

       
-

       
	slices.Reverse(tags)


     

       
98

       
 

       
	return tags, nil


     

       
99

       
 

       
}


     
···

       
2

       
 

       



     

       
3

       
 

       
import (


     

       
4

       
 

       
	"fmt"


     

       

       

       
     

       
5

       
 

       
	"strconv"


     

       
6

       
 

       
	"strings"


     

       
7

       
 

       
	"time"


     
···

       
34

       
 

       
	outFormat.WriteString("")


     

       
35

       
 

       
	outFormat.WriteString(recordSeparator)


     

       
36

       
 

       



     

       
37

       
+

       
	output, err := g.forEachRef(outFormat.String(), "--sort=-creatordate", "refs/tags")


     

       
38

       
 

       
	if err != nil {


     

       
39

       
 

       
		return nil, fmt.Errorf("failed to get tags: %w", err)


     

       
40

       
 

       
	}


     
···

       
93

       
 

       
		tags = append(tags, tag)


     

       
94

       
 

       
	}


     

       
95

       
 

       



     

       

       

       
     

       
96

       
 

       
	return tags, nil


     

       
97

       
 

       
}