back round 11 view raw

appview/models: add `NotificationTypeUserMentioned` notif type #737

merged

opened by

boltless.me 1 month ago targeting master from feat/mentions

Signed-off-by: Seongmin Lee git@boltless.me

options

unified split

Changed files

appview

models

notifications.go

pages

templates

notifications

fragments

item.html

appview/models/notifications.go

···

       20
        
       	NotificationTypeIssueReopen    NotificationType = "issue_reopen"

     

       21
        
       	NotificationTypePullClosed     NotificationType = "pull_closed"

     

       22
        
       	NotificationTypePullReopen     NotificationType = "pull_reopen"

     

       0
        
       
     

       23
        
       )

     

       24
        
       

     

       25
        
       type Notification struct {

     
···

       63
        
       		return "git-pull-request-create"

     

       64
        
       	case NotificationTypeFollowed:

     

       65
        
       		return "user-plus"

     

       0
        
       
     

       0
        
       
     

       66
        
       	default:

     

       67
        
       		return ""

     

       68
        
       	}

     
···

       113
        
       		return prefs.PullCreated // same pref for now

     

       114
        
       	case NotificationTypeFollowed:

     

       115
        
       		return prefs.Followed

     

       0
        
       
     

       0
        
       
     

       116
        
       	default:

     

       117
        
       		return false

     

       118
        
       	}

···

       20
        
       	NotificationTypeIssueReopen    NotificationType = "issue_reopen"

     

       21
        
       	NotificationTypePullClosed     NotificationType = "pull_closed"

     

       22
        
       	NotificationTypePullReopen     NotificationType = "pull_reopen"

     

       23
       +
       	NotificationTypeUserMentioned  NotificationType = "user_mentioned"

     

       24
        
       )

     

       25
        
       

     

       26
        
       type Notification struct {

     
···

       64
        
       		return "git-pull-request-create"

     

       65
        
       	case NotificationTypeFollowed:

     

       66
        
       		return "user-plus"

     

       67
       +
       	case NotificationTypeUserMentioned:

     

       68
       +
       		return "at-sign"

     

       69
        
       	default:

     

       70
        
       		return ""

     

       71
        
       	}

     
···

       116
        
       		return prefs.PullCreated // same pref for now

     

       117
        
       	case NotificationTypeFollowed:

     

       118
        
       		return prefs.Followed

     

       119
       +
       	case NotificationTypeUserMentioned:

     

       120
       +
       		return true // always notify on mention

     

       121
        
       	default:

     

       122
        
       		return false

     

       123
        
       	}

appview/pages/templates/notifications/fragments/item.html

···

       54
        
           reopened a pull request

     

       55
        
         {{ else if eq .Type "followed" }}

     

       56
        
           followed you

     

       0
        
       
     

       0
        
       
     

       57
        
         {{ else }}

     

       58
        
         {{ end }}

     

       59
        
       {{ end }}

···

       54
        
           reopened a pull request

     

       55
        
         {{ else if eq .Type "followed" }}

     

       56
        
           followed you

     

       57
       +
         {{ else if eq .Type "user_mentioned" }}

     

       58
       +
           mentioned you

     

       59
        
         {{ else }}

     

       60
        
         {{ end }}

     

       61
        
       {{ end }}