appview: use less OwnerSlashRepo() in handlers #802

···

       
312
       
 
       
		// notify about the issue closure

     

       
313
       
 
       
		rp.notifier.NewIssueState(r.Context(), syntax.DID(user.Did), issue)

     

       
314
       
 
       


     

       
315
       
-
       
		rp.pages.HxLocation(w, fmt.Sprintf("/%s/issues/%d", f.OwnerSlashRepo(), issue.IssueId))

     

       
0
       
 
       

     

       
316
       
 
       
		return

     

       
317
       
 
       
	} else {

     

       
318
       
 
       
		l.Error("user is not permitted to close issue")

     
···

       
362
       
 
       
		// notify about the issue reopen

     

       
363
       
 
       
		rp.notifier.NewIssueState(r.Context(), syntax.DID(user.Did), issue)

     

       
364
       
 
       


     

       
365
       
-
       
		rp.pages.HxLocation(w, fmt.Sprintf("/%s/issues/%d", f.OwnerSlashRepo(), issue.IssueId))

     

       
0
       
 
       

     

       
366
       
 
       
		return

     

       
367
       
 
       
	} else {

     

       
368
       
 
       
		l.Error("user is not the owner of the repo")

     
···

       
466
       
 
       
	}

     

       
467
       
 
       
	rp.notifier.NewIssueComment(r.Context(), &comment, mentions)

     

       
468
       
 
       


     

       
469
       
-
       
	rp.pages.HxLocation(w, fmt.Sprintf("/%s/issues/%d#comment-%d", f.OwnerSlashRepo(), issue.IssueId, commentId))

     

       
0
       
 
       

     

       
470
       
 
       
}

     

       
471
       
 
       


     

       
472
       
 
       
func (rp *Issues) IssueComment(w http.ResponseWriter, r *http.Request) {

     
···

       
970
       
 
       
			}

     

       
971
       
 
       
		}

     

       
972
       
 
       
		rp.notifier.NewIssue(r.Context(), issue, mentions)

     

       
973
       
-
       
		rp.pages.HxLocation(w, fmt.Sprintf("/%s/issues/%d", f.OwnerSlashRepo(), issue.IssueId))

     

       
0
       
 
       

     

       
0
       
 
       

     

       
974
       
 
       
		return

     

       
975
       
 
       
	}

     

       
976
       
 
       
}

     

···

       
312
       
 
       
		// notify about the issue closure

     

       
313
       
 
       
		rp.notifier.NewIssueState(r.Context(), syntax.DID(user.Did), issue)

     

       
314
       
 
       


     

       
315
       
+
       
		ownerSlashRepo := rp.repoResolver.GetBaseRepoPath(r, &f.Repo)

     

       
316
       
+
       
		rp.pages.HxLocation(w, fmt.Sprintf("/%s/issues/%d", ownerSlashRepo, issue.IssueId))

     

       
317
       
 
       
		return

     

       
318
       
 
       
	} else {

     

       
319
       
 
       
		l.Error("user is not permitted to close issue")

     
···

       
363
       
 
       
		// notify about the issue reopen

     

       
364
       
 
       
		rp.notifier.NewIssueState(r.Context(), syntax.DID(user.Did), issue)

     

       
365
       
 
       


     

       
366
       
+
       
		ownerSlashRepo := rp.repoResolver.GetBaseRepoPath(r, &f.Repo)

     

       
367
       
+
       
		rp.pages.HxLocation(w, fmt.Sprintf("/%s/issues/%d", ownerSlashRepo, issue.IssueId))

     

       
368
       
 
       
		return

     

       
369
       
 
       
	} else {

     

       
370
       
 
       
		l.Error("user is not the owner of the repo")

     
···

       
468
       
 
       
	}

     

       
469
       
 
       
	rp.notifier.NewIssueComment(r.Context(), &comment, mentions)

     

       
470
       
 
       


     

       
471
       
+
       
	ownerSlashRepo := rp.repoResolver.GetBaseRepoPath(r, &f.Repo)

     

       
472
       
+
       
	rp.pages.HxLocation(w, fmt.Sprintf("/%s/issues/%d#comment-%d", ownerSlashRepo, issue.IssueId, commentId))

     

       
473
       
 
       
}

     

       
474
       
 
       


     

       
475
       
 
       
func (rp *Issues) IssueComment(w http.ResponseWriter, r *http.Request) {

     
···

       
973
       
 
       
			}

     

       
974
       
 
       
		}

     

       
975
       
 
       
		rp.notifier.NewIssue(r.Context(), issue, mentions)

     

       
976
       
+
       


     

       
977
       
+
       
		ownerSlashRepo := rp.repoResolver.GetBaseRepoPath(r, &f.Repo)

     

       
978
       
+
       
		rp.pages.HxLocation(w, fmt.Sprintf("/%s/issues/%d", ownerSlashRepo, issue.IssueId))

     

       
979
       
 
       
		return

     

       
980
       
 
       
	}

     

       
981
       
 
       
}

     

···

       
164
       
 
       
			ok, err := mw.enforcer.E.Enforce(actor.Did, f.Knot, f.DidSlashRepo(), requiredPerm)

     

       
165
       
 
       
			if err != nil || !ok {

     

       
166
       
 
       
				// we need a logged in user

     

       
167
       
-
       
				log.Printf("%s does not have perms of a %s in repo %s", actor.Did, requiredPerm, f.OwnerSlashRepo())

     

       
168
       
 
       
				http.Error(w, "Forbiden", http.StatusUnauthorized)

     

       
169
       
 
       
				return

     

       
170
       
 
       
			}

     
···

       
327
       
 
       
				return

     

       
328
       
 
       
			}

     

       
329
       
 
       


     

       
330
       
-
       
			fullName := f.OwnerHandle() + "/" + f.Name

     

       
331
       
 
       


     

       
332
       
 
       
			if r.Header.Get("User-Agent") == "Go-http-client/1.1" {

     

       
333
       
 
       
				if r.URL.Query().Get("go-get") == "1" {

     

···

       
164
       
 
       
			ok, err := mw.enforcer.E.Enforce(actor.Did, f.Knot, f.DidSlashRepo(), requiredPerm)

     

       
165
       
 
       
			if err != nil || !ok {

     

       
166
       
 
       
				// we need a logged in user

     

       
167
       
+
       
				log.Printf("%s does not have perms of a %s in repo %s", actor.Did, requiredPerm, f.DidSlashRepo())

     

       
168
       
 
       
				http.Error(w, "Forbiden", http.StatusUnauthorized)

     

       
169
       
 
       
				return

     

       
170
       
 
       
			}

     
···

       
327
       
 
       
				return

     

       
328
       
 
       
			}

     

       
329
       
 
       


     

       
330
       
+
       
			fullName := mw.repoResolver.GetBaseRepoPath(r, &f.Repo)

     

       
331
       
 
       


     

       
332
       
 
       
			if r.Header.Get("User-Agent") == "Go-http-client/1.1" {

     

       
333
       
 
       
				if r.URL.Query().Get("go-get") == "1" {

     

···

       
21
       
 
       
	return path.Join(r.owner(), r.Name)

     

       
22
       
 
       
}

     

       
23
       
 
       


     

       
24
       
-
       
func (r RepoInfo) OwnerWithoutAt() string {

     

       
25
       
 
       
	if r.OwnerHandle != "" {

     

       
26
       
 
       
		return r.OwnerHandle

     

       
27
       
 
       
	} else {

     
···

       
30
       
 
       
}

     

       
31
       
 
       


     

       
32
       
 
       
func (r RepoInfo) FullNameWithoutAt() string {

     

       
33
       
-
       
	return path.Join(r.OwnerWithoutAt(), r.Name)

     

       
34
       
 
       
}

     

       
35
       
 
       


     

       
36
       
 
       
func (r RepoInfo) GetTabs() [][]string {

     

···

       
21
       
 
       
	return path.Join(r.owner(), r.Name)

     

       
22
       
 
       
}

     

       
23
       
 
       


     

       
24
       
+
       
func (r RepoInfo) ownerWithoutAt() string {

     

       
25
       
 
       
	if r.OwnerHandle != "" {

     

       
26
       
 
       
		return r.OwnerHandle

     

       
27
       
 
       
	} else {

     
···

       
30
       
 
       
}

     

       
31
       
 
       


     

       
32
       
 
       
func (r RepoInfo) FullNameWithoutAt() string {

     

       
33
       
+
       
	return path.Join(r.ownerWithoutAt(), r.Name)

     

       
34
       
 
       
}

     

       
35
       
 
       


     

       
36
       
 
       
func (r RepoInfo) GetTabs() [][]string {

     

···

       
800
       
 
       
		}

     

       
801
       
 
       
		s.notifier.NewPullComment(r.Context(), comment, mentions)

     

       
802
       
 
       


     

       
803
       
-
       
		s.pages.HxLocation(w, fmt.Sprintf("/%s/pulls/%d#comment-%d", f.OwnerSlashRepo(), pull.PullId, commentId))

     

       
0
       
 
       

     

       
804
       
 
       
		return

     

       
805
       
 
       
	}

     

       
806
       
 
       
}

     
···

       
1271
       
 
       


     

       
1272
       
 
       
	s.notifier.NewPull(r.Context(), pull)

     

       
1273
       
 
       


     

       
1274
       
-
       
	s.pages.HxLocation(w, fmt.Sprintf("/%s/pulls/%d", f.OwnerSlashRepo(), pullId))

     

       
0
       
 
       

     

       
1275
       
 
       
}

     

       
1276
       
 
       


     

       
1277
       
 
       
func (s *Pulls) createStackedPullRequest(

     
···

       
1372
       
 
       
		return

     

       
1373
       
 
       
	}

     

       
1374
       
 
       


     

       
1375
       
-
       
	s.pages.HxLocation(w, fmt.Sprintf("/%s/pulls", f.OwnerSlashRepo()))

     

       
0
       
 
       

     

       
1376
       
 
       
}

     

       
1377
       
 
       


     

       
1378
       
 
       
func (s *Pulls) ValidatePatch(w http.ResponseWriter, r *http.Request) {

     
···

       
1920
       
 
       
		return

     

       
1921
       
 
       
	}

     

       
1922
       
 
       


     

       
1923
       
-
       
	s.pages.HxLocation(w, fmt.Sprintf("/%s/pulls/%d", f.OwnerSlashRepo(), pull.PullId))

     

       
0
       
 
       

     

       
1924
       
 
       
}

     

       
1925
       
 
       


     

       
1926
       
 
       
func (s *Pulls) resubmitStackedPullHelper(

     
···

       
2113
       
 
       
		return

     

       
2114
       
 
       
	}

     

       
2115
       
 
       


     

       
2116
       
-
       
	s.pages.HxLocation(w, fmt.Sprintf("/%s/pulls/%d", f.OwnerSlashRepo(), pull.PullId))

     

       
0
       
 
       

     

       
2117
       
 
       
}

     

       
2118
       
 
       


     

       
2119
       
 
       
func (s *Pulls) MergePull(w http.ResponseWriter, r *http.Request) {

     
···

       
2231
       
 
       
		s.notifier.NewPullState(r.Context(), syntax.DID(user.Did), p)

     

       
2232
       
 
       
	}

     

       
2233
       
 
       


     

       
2234
       
-
       
	s.pages.HxLocation(w, fmt.Sprintf("/@%s/%s/pulls/%d", f.OwnerHandle(), f.Name, pull.PullId))

     

       
0
       
 
       

     

       
2235
       
 
       
}

     

       
2236
       
 
       


     

       
2237
       
 
       
func (s *Pulls) ClosePull(w http.ResponseWriter, r *http.Request) {

     
···

       
2303
       
 
       
		s.notifier.NewPullState(r.Context(), syntax.DID(user.Did), p)

     

       
2304
       
 
       
	}

     

       
2305
       
 
       


     

       
2306
       
-
       
	s.pages.HxLocation(w, fmt.Sprintf("/%s/pulls/%d", f.OwnerSlashRepo(), pull.PullId))

     

       
0
       
 
       

     

       
2307
       
 
       
}

     

       
2308
       
 
       


     

       
2309
       
 
       
func (s *Pulls) ReopenPull(w http.ResponseWriter, r *http.Request) {

     
···

       
2376
       
 
       
		s.notifier.NewPullState(r.Context(), syntax.DID(user.Did), p)

     

       
2377
       
 
       
	}

     

       
2378
       
 
       


     

       
2379
       
-
       
	s.pages.HxLocation(w, fmt.Sprintf("/%s/pulls/%d", f.OwnerSlashRepo(), pull.PullId))

     

       
0
       
 
       

     

       
2380
       
 
       
}

     

       
2381
       
 
       


     

       
2382
       
 
       
func newStack(f *reporesolver.ResolvedRepo, user *oauth.User, targetBranch, patch string, pullSource *models.PullSource, stackId string) (models.Stack, error) {

     

···

       
800
       
 
       
		}

     

       
801
       
 
       
		s.notifier.NewPullComment(r.Context(), comment, mentions)

     

       
802
       
 
       


     

       
803
       
+
       
		ownerSlashRepo := s.repoResolver.GetBaseRepoPath(r, &f.Repo)

     

       
804
       
+
       
		s.pages.HxLocation(w, fmt.Sprintf("/%s/pulls/%d#comment-%d", ownerSlashRepo, pull.PullId, commentId))

     

       
805
       
 
       
		return

     

       
806
       
 
       
	}

     

       
807
       
 
       
}

     
···

       
1272
       
 
       


     

       
1273
       
 
       
	s.notifier.NewPull(r.Context(), pull)

     

       
1274
       
 
       


     

       
1275
       
+
       
	ownerSlashRepo := s.repoResolver.GetBaseRepoPath(r, &f.Repo)

     

       
1276
       
+
       
	s.pages.HxLocation(w, fmt.Sprintf("/%s/pulls/%d", ownerSlashRepo, pullId))

     

       
1277
       
 
       
}

     

       
1278
       
 
       


     

       
1279
       
 
       
func (s *Pulls) createStackedPullRequest(

     
···

       
1374
       
 
       
		return

     

       
1375
       
 
       
	}

     

       
1376
       
 
       


     

       
1377
       
+
       
	ownerSlashRepo := s.repoResolver.GetBaseRepoPath(r, &f.Repo)

     

       
1378
       
+
       
	s.pages.HxLocation(w, fmt.Sprintf("/%s/pulls", ownerSlashRepo))

     

       
1379
       
 
       
}

     

       
1380
       
 
       


     

       
1381
       
 
       
func (s *Pulls) ValidatePatch(w http.ResponseWriter, r *http.Request) {

     
···

       
1923
       
 
       
		return

     

       
1924
       
 
       
	}

     

       
1925
       
 
       


     

       
1926
       
+
       
	ownerSlashRepo := s.repoResolver.GetBaseRepoPath(r, &f.Repo)

     

       
1927
       
+
       
	s.pages.HxLocation(w, fmt.Sprintf("/%s/pulls/%d", ownerSlashRepo, pull.PullId))

     

       
1928
       
 
       
}

     

       
1929
       
 
       


     

       
1930
       
 
       
func (s *Pulls) resubmitStackedPullHelper(

     
···

       
2117
       
 
       
		return

     

       
2118
       
 
       
	}

     

       
2119
       
 
       


     

       
2120
       
+
       
	ownerSlashRepo := s.repoResolver.GetBaseRepoPath(r, &f.Repo)

     

       
2121
       
+
       
	s.pages.HxLocation(w, fmt.Sprintf("/%s/pulls/%d", ownerSlashRepo, pull.PullId))

     

       
2122
       
 
       
}

     

       
2123
       
 
       


     

       
2124
       
 
       
func (s *Pulls) MergePull(w http.ResponseWriter, r *http.Request) {

     
···

       
2236
       
 
       
		s.notifier.NewPullState(r.Context(), syntax.DID(user.Did), p)

     

       
2237
       
 
       
	}

     

       
2238
       
 
       


     

       
2239
       
+
       
	ownerSlashRepo := s.repoResolver.GetBaseRepoPath(r, &f.Repo)

     

       
2240
       
+
       
	s.pages.HxLocation(w, fmt.Sprintf("/%s/pulls/%d", ownerSlashRepo, pull.PullId))

     

       
2241
       
 
       
}

     

       
2242
       
 
       


     

       
2243
       
 
       
func (s *Pulls) ClosePull(w http.ResponseWriter, r *http.Request) {

     
···

       
2309
       
 
       
		s.notifier.NewPullState(r.Context(), syntax.DID(user.Did), p)

     

       
2310
       
 
       
	}

     

       
2311
       
 
       


     

       
2312
       
+
       
	ownerSlashRepo := s.repoResolver.GetBaseRepoPath(r, &f.Repo)

     

       
2313
       
+
       
	s.pages.HxLocation(w, fmt.Sprintf("/%s/pulls/%d", ownerSlashRepo, pull.PullId))

     

       
2314
       
 
       
}

     

       
2315
       
 
       


     

       
2316
       
 
       
func (s *Pulls) ReopenPull(w http.ResponseWriter, r *http.Request) {

     
···

       
2383
       
 
       
		s.notifier.NewPullState(r.Context(), syntax.DID(user.Did), p)

     

       
2384
       
 
       
	}

     

       
2385
       
 
       


     

       
2386
       
+
       
	ownerSlashRepo := s.repoResolver.GetBaseRepoPath(r, &f.Repo)

     

       
2387
       
+
       
	s.pages.HxLocation(w, fmt.Sprintf("/%s/pulls/%d", ownerSlashRepo, pull.PullId))

     

       
2388
       
 
       
}

     

       
2389
       
 
       


     

       
2390
       
 
       
func newStack(f *reporesolver.ResolvedRepo, user *oauth.User, targetBranch, patch string, pullSource *models.PullSource, stackId string) (models.Stack, error) {

     

···

       
62
       
 
       
		return

     

       
63
       
 
       
	}

     

       
64
       
 
       


     

       
0
       
 
       

     

       
0
       
 
       

     

       
65
       
 
       
	// Use XRPC response directly instead of converting to internal types

     

       
66
       
 
       
	var breadcrumbs [][]string

     

       
67
       
-
       
	breadcrumbs = append(breadcrumbs, []string{f.Name, fmt.Sprintf("/%s/tree/%s", f.OwnerSlashRepo(), url.PathEscape(ref))})

     

       
68
       
 
       
	if filePath != "" {

     

       
69
       
 
       
		for idx, elem := range strings.Split(filePath, "/") {

     

       
70
       
 
       
			breadcrumbs = append(breadcrumbs, []string{elem, fmt.Sprintf("%s/%s", breadcrumbs[idx][1], url.PathEscape(elem))})

     

···

       
62
       
 
       
		return

     

       
63
       
 
       
	}

     

       
64
       
 
       


     

       
65
       
+
       
	ownerSlashRepo := rp.repoResolver.GetBaseRepoPath(r, &f.Repo)

     

       
66
       
+
       


     

       
67
       
 
       
	// Use XRPC response directly instead of converting to internal types

     

       
68
       
 
       
	var breadcrumbs [][]string

     

       
69
       
+
       
	breadcrumbs = append(breadcrumbs, []string{f.Name, fmt.Sprintf("/%s/tree/%s", ownerSlashRepo, url.PathEscape(ref))})

     

       
70
       
 
       
	if filePath != "" {

     

       
71
       
 
       
		for idx, elem := range strings.Split(filePath, "/") {

     

       
72
       
 
       
			breadcrumbs = append(breadcrumbs, []string{elem, fmt.Sprintf("%s/%s", breadcrumbs[idx][1], url.PathEscape(elem))})

     

···

       
79
       
 
       
		result.ReadmeFileName = xrpcResp.Readme.Filename

     

       
80
       
 
       
		result.Readme = xrpcResp.Readme.Contents

     

       
81
       
 
       
	}

     

       
0
       
 
       

     

       
82
       
 
       
	// redirects tree paths trying to access a blob; in this case the result.Files is unpopulated,

     

       
83
       
 
       
	// so we can safely redirect to the "parent" (which is the same file).

     

       
84
       
 
       
	if len(result.Files) == 0 && result.Parent == treePath {

     

       
85
       
-
       
		redirectTo := fmt.Sprintf("/%s/blob/%s/%s", f.OwnerSlashRepo(), url.PathEscape(ref), result.Parent)

     

       
86
       
 
       
		http.Redirect(w, r, redirectTo, http.StatusFound)

     

       
87
       
 
       
		return

     

       
88
       
 
       
	}

     

       
89
       
 
       
	user := rp.oauth.GetUser(r)

     

       
90
       
 
       
	var breadcrumbs [][]string

     

       
91
       
-
       
	breadcrumbs = append(breadcrumbs, []string{f.Name, fmt.Sprintf("/%s/tree/%s", f.OwnerSlashRepo(), url.PathEscape(ref))})

     

       
92
       
 
       
	if treePath != "" {

     

       
93
       
 
       
		for idx, elem := range strings.Split(treePath, "/") {

     

       
94
       
 
       
			breadcrumbs = append(breadcrumbs, []string{elem, fmt.Sprintf("%s/%s", breadcrumbs[idx][1], url.PathEscape(elem))})

     

···

       
79
       
 
       
		result.ReadmeFileName = xrpcResp.Readme.Filename

     

       
80
       
 
       
		result.Readme = xrpcResp.Readme.Contents

     

       
81
       
 
       
	}

     

       
82
       
+
       
	ownerSlashRepo := rp.repoResolver.GetBaseRepoPath(r, &f.Repo)

     

       
83
       
 
       
	// redirects tree paths trying to access a blob; in this case the result.Files is unpopulated,

     

       
84
       
 
       
	// so we can safely redirect to the "parent" (which is the same file).

     

       
85
       
 
       
	if len(result.Files) == 0 && result.Parent == treePath {

     

       
86
       
+
       
		redirectTo := fmt.Sprintf("/%s/blob/%s/%s", ownerSlashRepo, url.PathEscape(ref), result.Parent)

     

       
87
       
 
       
		http.Redirect(w, r, redirectTo, http.StatusFound)

     

       
88
       
 
       
		return

     

       
89
       
 
       
	}

     

       
90
       
 
       
	user := rp.oauth.GetUser(r)

     

       
91
       
 
       
	var breadcrumbs [][]string

     

       
92
       
+
       
	breadcrumbs = append(breadcrumbs, []string{f.Name, fmt.Sprintf("/%s/tree/%s", ownerSlashRepo, url.PathEscape(ref))})

     

       
93
       
 
       
	if treePath != "" {

     

       
94
       
 
       
		for idx, elem := range strings.Split(treePath, "/") {

     

       
95
       
 
       
			breadcrumbs = append(breadcrumbs, []string{elem, fmt.Sprintf("%s/%s", breadcrumbs[idx][1], url.PathEscape(elem))})

     

···

       
44
       
 
       
	return &RepoResolver{config: config, enforcer: enforcer, idResolver: resolver, execer: execer}

     

       
45
       
 
       
}

     

       
46
       
 
       


     

       
0
       
 
       

     

       
0
       
 
       

     

       
0
       
 
       

     

       
0
       
 
       

     

       
0
       
 
       

     

       
0
       
 
       

     

       
0
       
 
       

     

       
0
       
 
       

     

       
0
       
 
       

     

       
0
       
 
       

     

       
0
       
 
       

     

       
0
       
 
       

     

       
47
       
 
       
func (rr *RepoResolver) Resolve(r *http.Request) (*ResolvedRepo, error) {

     

       
48
       
 
       
	repo, ok := r.Context().Value("repo").(*models.Repo)

     

       
49
       
 
       
	if !ok {

     

···

       
44
       
 
       
	return &RepoResolver{config: config, enforcer: enforcer, idResolver: resolver, execer: execer}

     

       
45
       
 
       
}

     

       
46
       
 
       


     

       
47
       
+
       
// NOTE: this... should not even be here. the entire package will be removed in future refactor

     

       
48
       
+
       
func (rr *RepoResolver) GetBaseRepoPath(r *http.Request, repo *models.Repo) string {

     

       
49
       
+
       
	var (

     

       
50
       
+
       
		user = chi.URLParam(r, "user")

     

       
51
       
+
       
		name = chi.URLParam(r, "repo")

     

       
52
       
+
       
	)

     

       
53
       
+
       
	if user == "" || name == "" {

     

       
54
       
+
       
		return repo.DidSlashRepo()

     

       
55
       
+
       
	}

     

       
56
       
+
       
	return path.Join(user, name)

     

       
57
       
+
       
}

     

       
58
       
+
       


     

       
59
       
 
       
func (rr *RepoResolver) Resolve(r *http.Request) (*ResolvedRepo, error) {

     

       
60
       
 
       
	repo, ok := r.Context().Value("repo").(*models.Repo)

     

       
61
       
 
       
	if !ok {