back round 0 view raw

fix: xp not getting calculated correctly when a study session is deleted #22

merged

opened by

brookjeynes.dev 2 months ago targeting master from push-xlxvwwpkrpwv

Signed-off-by: brookjeynes me@brookjeynes.dev

options

unified split

Changed files

+4 -4

internal

consumer

ingester.go

+4 -4

internal/consumer/ingester.go

···

       263
       263
        
       		}

     

       264
       264
        
       

     

       265
       265
        
       		i.Logger.Debug("deleting study session from pds request")

     

       266
       266
       -
       		err = db.DeleteStudySessionByRkey(tx, did, e.Commit.RKey)

     

       266
       266
       +
       		err = db.RemoveXPForSession(tx, did, e.Commit.RKey, logger)

     

       267
       267
        
       		if err != nil {

     

       268
       268
        
       			tx.Rollback()

     

       269
       269
       -
       			return fmt.Errorf("failed to delete study session record: %w", err)

     

       269
       269
       +
       			return fmt.Errorf("failed to remove xp for session: %w", err)

     

       270
       270
        
       		}

     

       271
       271
        
       

     

       272
       272
       -
       		err = db.RemoveXPForSession(tx, did, e.Commit.RKey)

     

       272
       272
       +
       		err = db.DeleteStudySessionByRkey(tx, did, e.Commit.RKey)

     

       273
       273
        
       		if err != nil {

     

       274
       274
        
       			tx.Rollback()

     

       275
       275
       -
       			return fmt.Errorf("failed to remove xp for session: %w", err)

     

       275
       275
       +
       			return fmt.Errorf("failed to delete study session record: %w", err)

     

       276
       276
        
       		}

     

       277
       277
        
       

     

       278
       278
        
       		return tx.Commit()