Monorepo for Tangled โ€” https://tangled.org

appview: db: follow: add GetFollowers and GetFollowing functions to fetch Follows #483

merged
opened by ptr.pet targeting master from ptr.pet/core: followers-following-list
0
by ptr.pet 1 comment
expand 1 commit
appview: db: follow: add GetFollowers and GetFollowing functions to fetch Follows

this is pretty cool! couple of points:

  • the GetFollow* methods are a bit repetitive (in part due to the database/sql APIs), can we dedup them like we do in the rest of the codebase? the approach we use here is to write GetItem(e Execer, filters ...filter) ([]Item, error) and then use filters to create more specific getters. you can look at db/spindles for an example
  • we could do something similar for GetFollowStatus i think
sign up or login to add to the discussion
1
by ptr.pet 1 comment
expand 1 commit
appview: db: follow: add GetFollowers and GetFollowing functions to fetch Follows

made a GetFollows, and made the GetFollowers and GetFollowing use that (and also removed GetAllFollows since its not necessary with GetFollows)

sign up or login to add to the discussion
2
by ptr.pet 1 comment
expand 1 commit
appview: db: follow: add GetFollowers and GetFollowing functions to fetch Follows

oops T.T actually fixed it

pull request successfully merged
sign up or login to add to the discussion
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:dfl62fgb7wtjj3fcbb72naae/sh.tangled.repo.pull/3lwawsuk3dd22