tangled.org / core
Monorepo for Tangled — https://tangled.org
fork atom

appview: implement follower and following pages for users #484

merged
opened by ptr.pet targeting master from ptr.pet/core: followers-following-list
STACK 4
#505 appview: implement GetFollowersFollowingCounts to query follow stats for multiple dids in one go
0
#5
#504 appview: state: dedup profile pages
0
#5
#484 appview: implement follower and following pages for users
0
#13
#483 appview: db: follow: add GetFollowers and GetFollowing functions to fetch Follows
1
#2
ABANDONED PULLS 1
#482 appview: rename GetFollowerFollowing to GetFollowerFollowingCount
0
#0
0
by ptr.pet 0 comments
expand 1 commit
cbdbaf6d
appview: implement follower and following pages for users
sign up or login to add to the discussion
1
by ptr.pet 1 comment
expand 1 commit
cf9a2ce8
appview: implement follower and following pages for users
oppi.li

the pages themselves look pretty good for a start!

  • i'd like to add follower-following count to each item (to make these identical to the profile cards in the timeline)
  • this GetProfile call results in an N+1 query. we have a helper called GetProfiles to help with this, you can get profiles of multiple DIDs in one DB call. db/timeline.go has an example of the same.

overall, i'm loving this stack!

sign up or login to add to the discussion
2
by ptr.pet 0 comments
expand 1 commit
9643a898
appview: implement follower and following pages for users
sign up or login to add to the discussion
3
by ptr.pet 0 comments
expand 1 commit
0dfc15e9
appview: implement follower and following pages for users
sign up or login to add to the discussion
4
by ptr.pet 1 comment
expand 1 commit
90b0a392
appview: implement follower and following pages for users
ptr.pet

comments from #1 should be addressed now

on top of that changed GetProfiles to return a map instead of array, which seemed easier to do since it internally uses a map anyway and both places it's used in need it as a map

sign up or login to add to the discussion
5
by ptr.pet 1 comment
expand 1 commit
3c2d8223
appview: implement follower and following pages for users
ptr.pet

fixed some issues now that i got my dev setup working again

sign up or login to add to the discussion
6
by ptr.pet 0 comments
expand 1 commit
a285cd0f
appview: implement follower and following pages for users
sign up or login to add to the discussion
7
by ptr.pet 1 comment
expand 1 commit
a8bcde9d
appview: implement follower and following pages for users
ptr.pet

using resolve in html instead of resolving handles in go code, and dedupped followers/followingPage into followPage

sign up or login to add to the discussion
8
by ptr.pet 1 comment
expand 1 commit
ece60a35
appview: implement follower and following pages for users
ptr.pet
  • added following / follower page links to timeline and follow cards
  • also added followers and following to profile tab switch case
sign up or login to add to the discussion
9
by ptr.pet 1 comment
expand 1 commit
773aa964
appview: implement follower and following pages for users
ptr.pet
  • fixed timeline linking to wrong user (forgot to use subjectHandle instead of userHandle)
  • use ?tab= for followers / following like repo page does
  • fix repos opengraph url from /repos to ?tab=repos
sign up or login to add to the discussion
10
by ptr.pet 0 comments
expand 1 commit
7a5c931a
appview: implement follower and following pages for users
sign up or login to add to the discussion
11
by ptr.pet 0 comments
expand 1 commit
118fb342
appview: implement follower and following pages for users
sign up or login to add to the discussion
12
by ptr.pet 0 comments
expand 1 commit
98413d89
appview: implement follower and following pages for users
sign up or login to add to the discussion
13
by ptr.pet 0 comments
expand 1 commit
cb75b373
appview: implement follower and following pages for users
pull request successfully merged
sign up or login to add to the discussion
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:dfl62fgb7wtjj3fcbb72naae/sh.tangled.repo.pull/3lwawsuk3de22